Skip to content

BLD: remove blockslider #34014 #37006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

fangchenli
Copy link
Member

@fangchenli fangchenli commented Oct 9, 2020

Part of #34014

xref:
ivirshup@2c17e72
#34997

Impact on groupby

       before           after         ratio
     [97877442]       [a82d3773]
     <master^2>       <libreduction-cython>
+     5.07±0.06ms         43.8±1ms     8.65  groupby.Apply.time_scalar_function_single_col
+      15.5±0.2ms        108±0.6ms     6.97  groupby.Apply.time_scalar_function_multi_col
+         453±3ms          508±1ms     1.12  groupby.Apply.time_copy_overhead_single_col
+      1.44±0.03s       1.61±0.01s     1.12  groupby.Apply.time_copy_function_multi_col
-      26.0±0.7ms       23.4±0.2ms     0.90  groupby.Nth.time_frame_nth_any('float64')

Impact on index_cached_properties

       before           after         ratio
     [97877442]       [a82d3773]
     <master^2>       <libreduction-cython>
+        401±10ns        862±400ns     2.15  index_cached_properties.IndexCache.time_inferred_type('Int64Index')
+        397±10ns        649±200ns     1.64  index_cached_properties.IndexCache.time_is_unique('Int64Index')
+     1.01±0.03μs       1.31±0.2μs     1.30  index_cached_properties.IndexCache.time_values('DatetimeIndex')
+      3.51±0.2μs       4.55±0.8μs     1.29  index_cached_properties.IndexCache.time_shape('CategoricalIndex')
+      1.97±0.2μs       2.30±0.2μs     1.17  index_cached_properties.IndexCache.time_inferred_type('MultiIndex')
+     1.75±0.04μs       2.02±0.2μs     1.15  index_cached_properties.IndexCache.time_shape('DatetimeIndex')
-      1.99±0.3μs       1.58±0.2μs     0.79  index_cached_properties.IndexCache.time_values('UInt64Index')
-      2.33±0.6μs       1.77±0.5μs     0.76  index_cached_properties.IndexCache.time_inferred_type('Float64Index')

No significant changes on frame_methods

@jreback
Copy link
Contributor

jreback commented Oct 9, 2020

hmm, yeah i guess this perf regression is why BlockSlider exists in the first place.

@fangchenli
Copy link
Member Author

hmm, yeah i guess this perf regression is why BlockSlider exists in the first place.

yes... this is tricky

@jbrockmendel
Copy link
Member

xref #34997

@fangchenli
Copy link
Member Author

close for now.

@fangchenli fangchenli closed this Oct 10, 2020
@fangchenli fangchenli deleted the libreduction-cython branch October 10, 2020 21:32
@fangchenli fangchenli restored the libreduction-cython branch January 16, 2021 20:17
@fangchenli fangchenli reopened this Jan 16, 2021
@fangchenli fangchenli closed this Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants